Skip to content

MWPW-185414 - [M@S] Update references on commerce gallery page in MAS #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afmicka merged 5 commits into from
Jan 6, 2026
Merged

MWPW-185414 - [M@S] Update references on commerce gallery page in MAS #494

afmicka merged 5 commits into from
Jan 6, 2026

Conversation

@honstar
Copy link
Contributor

@honstar honstar commented Dec 18, 2025 •
edited by mirafedas
Loading

Resolves https://jira.corp.adobe.com/browse/MWPW-185414
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

  • use absolute URL to fetch spectrum-web-components dependencies
  • reformatted entire html document

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@honstar
MWPW-185414 - [M@S] Update references on commerce gallery page in MAS
ac2b925 
- use absolute URL to fetch spectrum-web-components dependencies
- reformatted entire html document
@aem-code-sync
Copy link

aem-code-sync bot commented Dec 18, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@afmicka
Copy link
Collaborator

afmicka commented Jan 5, 2026 •
edited
Loading

@honstar @3ch023 we have not enabled these pages to work with milolibs, right? Do we need it given that we load files from milo?

@3ch023
Copy link
Contributor

3ch023 commented Jan 5, 2026

@honstar @3ch023 we have not enabled these pages to work with milolibs, right? Do we need it given that we load files from milo?

i think we could skip it here..
worst think i could imagine happening is someone updating those files in milo and breaking Commerce cards gallery. It would be unpleasant but not a cso, so leaving it to @honstar 's consideration

@honstar
Copy link
Contributor Author

honstar commented Jan 5, 2026

@honstar @3ch023 we have not enabled these pages to work with milolibs, right? Do we need it given that we load files from milo?

i think we could skip it here.. worst think i could imagine happening is someone updating those files in milo and breaking Commerce cards gallery. It would be unpleasant but not a cso, so leaving it to @honstar 's consideration

Are consumers of mas making direct use of the shared spectrum components that we make available at https://www.adobe.com/libs/features/spectrum-web-components/dist/*? If yes, we might want to support milolibs to be able to test changes to the components above before rolling these out.

@afmicka afmicka merged commit b45342f into main Jan 6, 2026
14 of 15 checks passed
@afmicka afmicka deleted the MWPW-185414 branch January 6, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3ch023 3ch023 3ch023 approved these changes

@mirafedas mirafedas mirafedas approved these changes

Assignees

No one assigned

Labels

run nala verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@honstar @afmicka @3ch023 @mirafedas